Michael Brown has posted comments on this change.

Change subject: IMPALA-4904,IMPALA-4914: add targeted-stress to exhaustive tests
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6002/3//COMMIT_MSG
Commit Message:

Line 7: IMPALA-4904,IMPALA-4914: whitelist workload "targeted-stress" for 
exhaustive tests
> Thanks for the point Henry. I once saw on an Impala code review (I can't fi
Done


http://gerrit.cloudera.org:8080/#/c/6002/3/tests/stress/test_ddl_stress.py
File tests/stress/test_ddl_stress.py:

Line 59
> Given the number of catalog race conditions we tend to see, I think it is p
TEST_IDS (LHS L45) is equivalent to RHS L52. The RHS is simply the standard 
py.test way of going it. The real difference here is the introduction of 
unique_database, which I agree removes the potential of "CREATE DATABASE IF NOT 
EXISTS ddl_stress_testdb"  to be run concurrently. From a test perspective, 
partially reverting this to the previous behavior should not cause the test to 
fail. Let me address that in a separate patch set.


-- 
To view, visit http://gerrit.cloudera.org:8080/6002
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6bd5bbd380e636d680368e908519b042d79dfec
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to