Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3905: Implements HdfsScanner::GetNext() for text scans. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6000/1/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 243: Status HdfsTextScanner::FinishScanRange(RowBatch* row_batch) { is there some better way to arrange the functions in this file to facilitate the comparison? manually piecing together the diff is a bit hard. http://gerrit.cloudera.org:8080/#/c/6000/1/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 33: enum TextScanState { move into hdfstextscanner, or is this needed outside? Line 189: int WriteFields(MemPool* pool, TupleRow* row, int num_fields, int num_tuples); output or in/out params go at end -- To view, visit http://gerrit.cloudera.org:8080/6000 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id193aa223434d7cc40061a42f81bbb29dcd0404b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
