John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 5 of "Cloudera Manager" removal. Most of these fixes entailed hiding the paragraph where there are mentions of CM and writing a replacement paragraph for the upstream docs. This removes the CM references from the rendered docs. A ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/6070/1/docs/topics/impala_isilon.xml File docs/topics/impala_isilon.xml: PS1, Line 90: Watch out for all these trailing spaces. (Let's see if we can adapt the 'eat trailing spaces' fixup code from our usual pre-commit hook for this Apache work.) PS1, Line 103: audience="hidden" Since you rewrote the paragraph in a way that's similar to the original, I don't think this audience="hidden" copy is still needed. http://gerrit.cloudera.org:8080/#/c/6070/1/docs/topics/impala_logging.xml File docs/topics/impala_logging.xml: PS1, Line 392: <p audience="hidden"> : Impala uses the GLOG system, which supports three logging levels. You can adjust the logging levels using : the Cloudera Manager Admin Console. You can adjust logging levels without going through the Cloudera : Manager Admin Console by exporting variable settings. To change logging settings manually, use a command : similar to the following on each node before starting <codeph>impalad</codeph>: : </p> Since you rewrote the paragraph in a way that's similar to the original, I don't think this audience="hidden" copy is still needed. PS1, Line 477: <p audience="hidden"> Since you rewrote the paragraph in a way that's similar to the original, I don't think this audience="hidden" copy is still needed. http://gerrit.cloudera.org:8080/#/c/6070/1/docs/topics/impala_webui.xml File docs/topics/impala_webui.xml: PS1, Line 58: <p audience="hidden"> Since you rewrote the paragraph in a way that's similar to the original, I don't think this audience="hidden" copy is still needed. PS1, Line 103: <note audience="hidden"> Since you rewrote the paragraph in a way that's similar to the original, I don't think this audience="hidden" copy is still needed. PS1, Line 233: <p audience="hidden"> Since you rewrote the paragraph in a way that's similar to the original, I don't think this audience="hidden" copy is still needed. PS1, Line 283: For the meanings of these metrics, see : <xref href="http://www.cloudera.com/documentation/enterprise/latest/topics/cm_metrics_impala.html"; scope="external" format="html"> Here's one maybe for Jim. Is there a github page where someone can see in the source code the metrics and maybe an associated comment for each one? -- To view, visit http://gerrit.cloudera.org:8080/6070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4967fae275a8822274aece14a15107237445aba5 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-HasComments: Yes
