John Russell has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. Most of these fixes involved hiding the paragraphs with the DITA attribute 'audience="hidden"' and then inserting a paragraph suitable for upstream documentation. This hides the mention of Cloudera ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6069/1//COMMIT_MSG Commit Message: PS1, Line 7: IMPALA-3401 [DOCS] Part 4 of "Cloudera Manager" removal. In the commit message, have a blank line after this one. Otherwise it's treated like a single very long line in notifications. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS1, Line 1475: or the : equivalent configuration option in your cluster management software I would say just take out the whole phrase. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_resources.xml File docs/topics/impala_perf_resources.xml: PS1, Line 78: such as cgroups Question for MJ, whether the reference to cgroups is appropriate anymore at all. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_perf_testing.xml File docs/topics/impala_perf_testing.xml: PS1, Line 46: : Watch out for trailing spaces or tabs on these new blank lines. http://gerrit.cloudera.org:8080/#/c/6069/1/docs/topics/impala_txtfile.xml File docs/topics/impala_txtfile.xml: PS1, Line 505: On systems using cluster management software or those not using cluster management : software That's a little bit convoluted phrasing. Let's find an SME on the dev team who can sanity check the LZO setup instructions and add them as a reviewer. -- To view, visit http://gerrit.cloudera.org:8080/6069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c3c2177e0b9c4c81f1541820013c66a59c0c7b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-HasComments: Yes
