Michael Ho has posted comments on this change. Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6038/4//COMMIT_MSG Commit Message: PS4, Line 25: types > values Done. This may seem like a concern in the long run, isn't it ? http://gerrit.cloudera.org:8080/#/c/6038/4/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: PS4, Line 338: Our implementation is similar to MS SQL which takes the max of the input's scale : // and MIN_ADJUSTED_SCALE. > How about explaining why we deviate from SQL Server and from SUM()/COUNT(): Done -- To view, visit http://gerrit.cloudera.org:8080/6038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28f5ef0370938440eb5b1c6d29b2f24e6f88499f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
