Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics ......................................................................
Patch Set 7: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/6032/6/be/src/exec/parquet-column-stats.h File be/src/exec/parquet-column-stats.h: Line 31: /// writing parquet files. It provides an interface to populate a parquet::Statistics > The other two values are i64 null_count and i64 distinct_count, for which I i think you can leave the getters out for now, since we won't be calling them, but for the sake of completeness we should add the other two enums. http://gerrit.cloudera.org:8080/#/c/6032/7/be/src/exec/parquet-column-stats.h File be/src/exec/parquet-column-stats.h: Line 68: static bool ReadFromThrift(const parquet::Statistics& thrift_stats, who calls this? http://gerrit.cloudera.org:8080/#/c/6032/7/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: Line 55: options.setExplain_level(TExplainLevel.VERBOSE); i thought the stats predicates are visible in extended? -- To view, visit http://gerrit.cloudera.org:8080/6032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b836165756fcf929c801048d91c50c8fdcdae4 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-HasComments: Yes
