Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3410 [DOCS] Rework Impala authentication topics to be generic ......................................................................
Patch Set 5: (8 comments) Addressed all of John's comments. http://gerrit.cloudera.org:8080/#/c/5962/5/docs/shared/impala_common.xml File docs/shared/impala_common.xml: PS5, Line 566: , > Remove comma. Done http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_delegation.xml File docs/topics/impala_delegation.xml: PS5, Line 79: <!-- Link to Cloudera blog post - Remove? --> > Is there a generic alternative place to link? If not, my impulse is to leav I couldn't find a suitable upstream alternative. Left this in place. PS5, Line 100: <!-- Link to Cloudera ODBC driver doc - Remove? --> > Could genericize this to "consult the documentation for the ODBC driver you Done http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_kerberos.xml File docs/topics/impala_kerberos.xml: PS5, Line 47: <xref > With the <keydef> in place, this can be shortened to Done PS5, Line 62: > Take out any spaces or tabs that are left behind in new blank lines. Done PS5, Line 144: <xref > This can also be shortened to an <xref keyref=.../> tag, referencing the ke Done PS5, Line 178: <p conref > Not critical in this case, but for future reference. If any of the list ite Will do in the future. This one I've left as is. http://gerrit.cloudera.org:8080/#/c/5962/5/docs/topics/impala_ldap.xml File docs/topics/impala_ldap.xml: PS5, Line 164: on the command line > Take out that phrase, because often the daemons are started by a script and Done -- To view, visit http://gerrit.cloudera.org:8080/5962 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I639a55eb43555cf074c26d23b5c72f778073231c Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen Kazi <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Laurel Hale <[email protected]> Gerrit-HasComments: Yes
