Michael Ho has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts ......................................................................
Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/22/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: PS22, Line 54: UNLIKELY(std::isnan(d)) || UNLIKELY(std::fabs(d) >= max_value)) > clang at least generates better code with the double UNLIKELY form. It see I am fine to keep the code as-is. Based on the offline discussion, your assumption is that forward jump tends to be predicted as not taken. Also, we use clang to compile fucntions to IR and not machine code. It may be more useful to find out how the IR generated is different with these UNLIKELY combinations and the implication to other usages of UNLIKELY or LIKELY in the code. -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 22 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
