Alex Behm has posted comments on this change. Change subject: IMPALA-4848: Add WIDHT_BUCKET() function ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6023/3/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: Line 456: if (bucket_width == numeric_limits<float>::infinity()) { > I don't think infinity is possible unless our min/max range are already wei To simplify the handling of these strange cases, you might consider using DECIMAL instead of double throughout. -- To view, visit http://gerrit.cloudera.org:8080/6023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081bc916b1bef7b929ca161a9aade3b54c6b858f Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
