Marcel Kornacker has posted comments on this change. Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler ......................................................................
Patch Set 1: (1 comment) thanks for picking this up. for the purpose of simplifying the review, could you do me a favor and revert the rename of simple-scheduler.* for now (and simply drop scheduler.*)? that'll make a side-by-side comparison a lot easier. http://gerrit.cloudera.org:8080/#/c/6149/1/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: Line 18: #ifndef SCHEDULING_SIMPLE_SCHEDULER_H revert. -- To view, visit http://gerrit.cloudera.org:8080/6149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70e0b002fa56d3ba1c3b34f03ae05f4042ac309e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
