Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4983: Set toolchain version to include LZ4 build flags ......................................................................
Patch Set 1: This does raise an interesting limitation of how we version the toolchain binaries, specifically that we don't have great insight into how a toolchain build was built. I think it's fine for now but it seems like we should have a way to identify the git hash of the native-toolchain used to build a particular "build ID", since that would identify the build flags used for that build ID. I'll file a JIRA for that. I assume this has passed tests with the new lz4 bits? -- To view, visit http://gerrit.cloudera.org:8080/6165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9244188d44523227bab487a58f23954c4727c71 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: No
