Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes ......................................................................
Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 40 > This mechanism exists so that we can configure Impala's logging in one plac > I don't think we should introduce the burden of having them configured > separately - is that what this change now implies? No. the users can still configure it from a single place > Is trace logging off by default? TRACE logging is ON/OFF depending on how users configure GLOG (ex: JniCatalog/JniFrontend still call GlogAppender.Install() based on --v). > We should expect that 95% of deployments won't use this feature for > fine-grained control, so the out-of-the-box behaviour has to be good enough > for them. Yes. Like I mentioned above, this patch doesn't break any existing way of configuring logging. We still configure it using the central GLOG config. I think there is some disconnect in my understanding here. This patch doesn't break any existing ways per my understanding. May be we can chat offline to clear it out. Apologies for the back and forth. -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
