Dan Hecht has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests ......................................................................
Patch Set 1: > Looks simple and correct. Maybe add a 39 digit overflow test and a > 39 digit leading zero decimal(38,38) underflow? Done. Can you take another look? -- To view, visit http://gerrit.cloudera.org:8080/6150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd66c0fb5a4d201919d39f73dea08b87339d6469 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: No
