Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6132/6/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 113: result = BitUtil::IncrementAwayFromZero(result); Same bug strikes here. Will add a test for: cast(cast(-1 * pow(1, -38) as decimal(38,38)) as bigint) which returns, you guessed: 1 Line 210: result = BitUtil::IncrementAwayFromZero(result); Ditto, although we can't really test this code yet. Will mark with a TODO Line 345: r = BitUtil::IncrementAwayFromZero(r); Unaffected. -- To view, visit http://gerrit.cloudera.org:8080/6132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6bfcbe37555b74598d409c6f84f06b0ae5c4312 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
