Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5888/1/be/src/service/impala-internal-service.cc File be/src/service/impala-internal-service.cc: Line 66: > sync callback ? AddData func may block some time that will cause many work You are correct, but those changes are to come in a subsequent patch which changes the protocol a bit. -- To view, visit http://gerrit.cloudera.org:8080/5888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95229290566a8ccffd80ed2d74c1c57cf1479238 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: Yes
