Tim Armstrong has posted comments on this change. Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6226/2/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: Line 34: if (col_stats < std::numeric_limits<int8_t>::min() || col_stats isn't valid if ret is false, right? Line 39: DCHECK(false); I don't think we should DCHECK here - users do sometimes run DEBUG builds on their clusters (often their dev environment). Line 50: if (col_stats < std::numeric_limits<int16_t>::min() || See above comments. -- To view, visit http://gerrit.cloudera.org:8080/6226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b10508db53747e7b08c8bd9a69c763b82135a78 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes