Jim Apple has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings ......................................................................
Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5902/5//COMMIT_MSG Commit Message: PS5, Line 38: 0.83s > what do you mean exactly? I mean run the test a few times and provide something like https://en.wikipedia.org/wiki/Interquartile_range so we know if it sped things up or slowed them down. http://gerrit.cloudera.org:8080/#/c/5902/5/be/src/util/decimal-util.h File be/src/util/decimal-util.h: Line 57: template<typename T> > Done Neither looks done in PS9: private or rename PS5, Line 58: T > Not necessarily, this would work for float / double as well. I'm not so sure: it would lose precision there in the low bits. PS5, Line 59: boost:: > I'll try it It helps me keep track of comments on patches when they are responded to only when the ball is back in my court. Line 60: return scale == 0 ? 1 : 10 * GetConstScaleMultiplier<T>(scale-1); > I think it can be done, not sure how simply. Since this is constexpr, we a Why not just another '?:' operator? Line 136: if (__builtin_const_p(scale) && p < 10) return GetConstScaleMultiplier<int32_t>(scale); > Let's remove it and find out. Please post the numbers here when you have decided. -- To view, visit http://gerrit.cloudera.org:8080/5902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5095a366d914cebb0b64bd434a08dbb55c90ed30 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
