Laurel Hale has posted comments on this change. Change subject: IMPALA-3401 [DOCS] Phase 3 of removing Cloudera Manager from upstream docs. ......................................................................
Patch Set 2: (8 comments) Ambreen, I've answered your comments, can you take a look and +1 if all looks in order? Thanks. http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: PS1, Line 336: > Isn't this too blunt an instrument to hide the whole <li>? Everything under Done http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: Line 114: Consider enabling <q>sticky sessions</q>. <ph rev="upstream">Cloudera</ph> recommends enabling this setting > 'Cloudera' John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. PS2, Line 261: CDH Secu > CDH reference John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_resource_management.xml File docs/topics/impala_resource_management.xml: Line 357: <p rev="2.0.0"> > this whole concept is only left with one line -- which isn't even a limitat John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other issues will be addressed in subsequent cleanup tasks. http://gerrit.cloudera.org:8080/#/c/6067/1/docs/topics/impala_timeouts.xml File docs/topics/impala_timeouts.xml: PS1, Line 188: Various client applications > We may as well preserve part of this sentence, at least the example of: Done http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_timeouts.xml File docs/topics/impala_timeouts.xml: PS2, Line 43: CDH > Remove CDH. John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. http://gerrit.cloudera.org:8080/#/c/6067/2/docs/topics/impala_udf.xml File docs/topics/impala_udf.xml: Line 425: Start at <xref href="https://archive.cloudera.com/cdh5/"; scope="external" format="html"/> for the CDH 5 > Are there links to upstream repos that can replace these? John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. PS2, Line 433: CDH 4 > CDH4-specific info you could probably delete. John asked me to confine my changes to only addressing the references to "Cloudera Manager." Other proprietary references will be removed in subsequent cleanup tasks. -- To view, visit http://gerrit.cloudera.org:8080/6067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4748300edc43b7071afc50e7cc7ddd64120c0d8d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Laurel Hale <[email protected]> Gerrit-Reviewer: Ambreen Kazi <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Laurel Hale <[email protected]> Gerrit-HasComments: Yes
