Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5027: make udf headers buildable externally ......................................................................
IMPALA-5027: make udf headers buildable externally This fixes a number of issues that prevented building it: * Use of C++11 features * Use of internal headers that are only available in the Impala source tree Testing: Copied the headers and libImpalaUdf.a to /usr and confirmed I could build impala-udf-samples (with some modifications to udf-test-harness to use some modified arguments to the test harness). We really need a better solution for automatically testing this, e.g. IMPALA-5026, but I wanted to fix the known bugs first. Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e Reviewed-on: http://gerrit.cloudera.org:8080/6251 Reviewed-by: Matthew Jacobs <[email protected]> Reviewed-by: Dan Hecht <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/udf/uda-test-harness-impl.h M be/src/udf/uda-test-harness.h M be/src/udf/udf-debug.h M be/src/udf/udf-test-harness.h M be/src/udf/udf.h 5 files changed, 45 insertions(+), 15 deletions(-) Approvals: Impala Public Jenkins: Verified Matthew Jacobs: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdcdcd96c953cbabc3de04ca66d7aa1774ada99e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
