Bharath Vissapragada has posted comments on this change.

Change subject: Fix a potential crash in Frontend & Catalog JNI startup
......................................................................


Patch Set 3:

(1 comment)

>If you get rid of the local frame, do you still need to promote to a global 
>ref?

I thought about it and ran the full core test suite without promoting it to 
global refs and it passed. I still retained the code just to be on a safer side 
as I don't fully understand the life cycle of these references. Anyway, I'm not 
too strong about it. Removing it from PS3.

http://gerrit.cloudera.org:8080/#/c/6264/2//COMMIT_MSG
Commit Message:

PS2, Line 9: Fronten
> typo
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35398a8efdb6fdbf7932a32489b2ad8d99b6d76f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-HasComments: Yes

Reply via email to