Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6247
to look at the new patch set (#2).
Change subject: IMPALA-5025: upgrade to binutils 2.26.1
......................................................................
IMPALA-5025: upgrade to binutils 2.26.1
This has two fixes that we care about:
* The slow linking problem that the -p1 patch to 2.26 solved
* A way to disable emitting relocations R_X86_64_GOTPCRELX and
R_X86_64_REX_GOTPCRELX that aren't supported by older linkers.
We configure binutils to disable these by default to be as safe
as possible.
Testing:
Built Impala locally with 2.26-p1 and 2.26.1 and inspected
libImpalaUdf.a with objdump -x to make sure that the relocation
types changed to ensure that the change had an effect.
Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
---
M init.sh
M source/binutils/build.sh
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain
refs/changes/47/6247/2
--
To view, visit http://gerrit.cloudera.org:8080/6247
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0de3b30f6ade4a3fab77572caac7be3a8d018105
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
