Joe McDonnell has posted comments on this change. Change subject: IMPALA-5038: Fix file size regex to include bytes ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6288/1//COMMIT_MSG Commit Message: Line 9: There is a regex to remove file sizes from test logs to avoid diffs caused > long lines Done http://gerrit.cloudera.org:8080/#/c/6288/1/fe/src/test/java/org/apache/impala/testutil/TestUtils.java File fe/src/test/java/org/apache/impala/testutil/TestUtils.java: Line 88: // File size could vary from run to run. For example, parquet file header size could > please also fix the grammar of this comment Done Line 99: return input.replaceAll(FILTER_KEY + NUMBER_FILTER + BYTE_FILTER, FILTER_KEY); > is this a case-sensitive match? Yes, this is case-sensitive. -- To view, visit http://gerrit.cloudera.org:8080/6288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f7b8480065a4da63c8abaf53aae8aef772f0172 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
