Alex Behm has posted comments on this change. Change subject: IMPALA-5039: Fix variability in parquet dictionary filtering test ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6301/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: Line 172: def _parquet_filtering_helper(self, table_name, condition, rows, row_groups, This looks like a generally useful extension to the existing test infrastructure. For example, we have similar test issues with the min/max filtering where we just set num_nodes=1 today. I think it's worth thinking about extending the framework instead of doing a one-off here. For example, maybe you could have something like: ---- RUNTIME_PROFILE aggregate: SUM(RowsPassedThrough) = 10 or something along those lines. I don't think it will end up being much more code to change the test infra. Happy to discuss if you have other ideas or thoughts. -- To view, visit http://gerrit.cloudera.org:8080/6301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b7b84d973b3ac678a24e82900f2637d569158bb Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
