Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough ......................................................................
Patch Set 11: > > (2 comments) > > > > Dan, I don't think multiple row batches are necessary to exercise > > the close on next getnext call. Even if a child returns a single > > batch, that logic will be exericed. > > That doesn't seem to be the case looking at > PlanFragmentExecutor::ExecInternal(). > Besides, if it is the case, that could easily change in the > future, so I don't think it's good to rely on that for coverage. Hmm, I guess it's true for union-node because we never set *eos=true when returning pass through rows, unless there is a limit. That seems weird -- is that intentional? -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
