John Russell has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). ......................................................................
Patch Set 2: Since I got the +1 from Zoltan, and I'd classify the subsequent suggestions as nice-to-have but not essential, any objection to my +2'ing it now and revisiting improvements later? -- To view, visit http://gerrit.cloudera.org:8080/5589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No
