Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough ......................................................................
Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.cc File be/src/exec/union-node.cc: Line 156: // It is OK to close the child here because all RowBatches have already been ... because all tuple data has been copied, and we will not be calling ... Line 174: child_batch_.reset(); move this before ++child_idx_ to have them clustered? http://gerrit.cloudera.org:8080/#/c/5816/13/be/src/exec/union-node.h File be/src/exec/union-node.h: Line 67: /// Children that can be passed through, without evaluating and materializing their single line Line 109: inline bool AtEos(int per_fragment_instance_idx) const { Maybe it's clearer to make GetNextPassThrough() not set eos, and instead have all the *eos setting be done directly inside GetNext(). That way each place different place can do the appropriate checks. Line 119: DCHECK_LE(child_idx_, children_.size()); Checking of the child_idx_ is dependent on the aller pattern of advancing the child_idx_ and calling into this AtEos(), another argument for maybe inlining the checks into GetNext() to make this subtle point less disconnected. -- To view, visit http://gerrit.cloudera.org:8080/5816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8f6d5062724ba5b78174c3227a7a796d10d8416 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
