Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 1: Free list implementation ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6410/6/be/src/runtime/bufferpool/free-list-test.cc File be/src/runtime/bufferpool/free-list-test.cc: Line 112: vector<const void*> addrs = GetSortedAddrs(buffers); > can also be a const vector Done http://gerrit.cloudera.org:8080/#/c/6410/6/be/src/runtime/bufferpool/free-list.h File be/src/runtime/bufferpool/free-list.h: Line 117: return SortCompare(b2, b1); > You might want to leave a note on FreeBuffers that its complexity is Theta( Done. In the caller I'm going to always remove a fixed percentage of the entries p when the list gets full, so overall it should be amortised log n time, since FreeBuffers() will be called only ones every (p * n) operations. http://gerrit.cloudera.org:8080/#/c/6410/7/be/src/runtime/bufferpool/free-list.h File be/src/runtime/bufferpool/free-list.h: PS7, Line 51: over > "into" Done -- To view, visit http://gerrit.cloudera.org:8080/6410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia89acfa4efdecb96d3678443b4748932b4133b9b Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
