Tim Armstrong has posted comments on this change. Change subject: IMPALA-4673: Use --local_library_dir for tzdb startup scratch space ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5523/5/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 7076: TimezoneDatabase::Initialize(); Check the return Status here? It would be good to add WARN_UNUSED_RESULT to Initialize() as well just to make sure it's not dropped (we should do this in a lot of places but it's good to fix things as we touch them). -- To view, visit http://gerrit.cloudera.org:8080/5523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ab0238e6ce65ca39c167349e3b79aa70fb39d2f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
