Tim Armstrong has posted comments on this change. Change subject: IMPALA-4758: (1/2) Update gutil/ from Kudu@a1bfd7b ......................................................................
Patch Set 4: (2 comments) Looks like this accidentally reverted some deliberate changes we made. Otherwise looks fine. http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/atomicops-internals-x86.h File be/src/gutil/atomicops-internals-x86.h: Line 46: bool has_amd_lock_mb_bug; // Processor has AMD memory-barrier bug; do lfence This code was deliberately removed in commit a7c3f301bb1da14d6bb35d37aab47450c67cca0c Author: Dan Hecht <[email protected]> Date: Wed Mar 9 14:34:10 2016 -0800 Remove AMD Opteron Rev E workaround from atomicops http://gerrit.cloudera.org:8080/#/c/5687/4/be/src/gutil/bits.h File be/src/gutil/bits.h: Line 141 It looks you reverted: commit 92fafa1c0687141481e56ea6f09a67987d571d6e Author: Tim Armstrong <[email protected]> Date: Fri Apr 8 10:23:03 2016 -0700 Use more efficient gutil implementation of Log2Ceiling I think you mentioned that something changed here to me in person but I misunderstood what the actual change was. If we want to avoid future conflicts we could just add the optimised version to our BitUtil and switch over the users. -- To view, visit http://gerrit.cloudera.org:8080/5687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic708a9c4e76ede17af9b06e0a0a8e9ae7d357960 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
