Lars Volker has posted comments on this change. Change subject: IMPALA-5110: Add deb support to dump_breakpad_symbols.py ......................................................................
Patch Set 2: (3 comments) Thank you for the review. Please see my comments and PS2. http://gerrit.cloudera.org:8080/#/c/6462/1/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: Line 115: parser.add_argument('-r', '--pkg', '--rpm', help="""RPM/DEB file containing the binaries > Instead of adding a flag for every package type, should we just add a gener Done. I changed the flag name so we don't have to worry about compatibility in the future. However I kept the help string as I have only seen RPM and DEB being used to package Impala and the code below won't work with anything else. Line 117: parser.add_argument('-s', '--symbol_pkg', '--debuginfo_rpm', help="""RPM/DEB file > Same here - --symbol_pkg or similar? Done Line 208: logging.info('Extracting to %s: %s' % (tmp_dir, pkg)) > Mention the output directory? Might be helpful for debugging if it fails. Done. The output directory will be removed in case of failure though. -- To view, visit http://gerrit.cloudera.org:8080/6462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I524d2fe4660551c2fe4ff190b7e5bbb33d986b10 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
