Tim Armstrong has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5688/6/be/src/common/atomic.h File be/src/common/atomic.h: Line 104: return base::subtle::Release_CompareAndSwap(&value_, old_val, new_val) == old_val; It looks like Barrier_CompareAndSwap was added by Dan to gutils in the below commit. I'm not sure of the subtleties here, so I'll defer to him about whether it's equivalent. commit 152c586f398269856169c271c771484793fdfee9 Author: Dan Hecht <[email protected]> Date: Wed Feb 17 16:33:35 2016 -0800 Improve AtomicInt abstraction and implementation -- To view, visit http://gerrit.cloudera.org:8080/5688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
