Tim Armstrong has posted comments on this change. Change subject: IMPALA-5115: Handle status from HdfsTableSink::WriteClusteredRowBatch ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6486/1/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: Line 630: RETURN_IF_ERROR(WriteClusteredRowBatch(state, batch)); > Done. I tried compiling with WARN_UNUSED_RESULT but without RETURN_IF_ERROR It's a gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38172 Clang isn't affected by it, so we'll catch it in GVO with clang-tidy. -- To view, visit http://gerrit.cloudera.org:8080/6486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6f5d87ae5e46d6019d9988011d3f2657e81ae15 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
