Henry Robinson has posted comments on this change. Change subject: IMPALA-4041: Limit catalog and admission control updates to coordinators ......................................................................
Patch Set 5: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS5, Line 180: node can coordinate queries. maybe tighten this up: "If true, this Impala daemon can accept and coordinate queries from clients. If false, this daemon will only execute query fragments, and will refuse client connections.". http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 949: comment? http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/service/query-exec-state.cc File be/src/service/query-exec-state.cc: PS5, Line 461: if (!FLAGS_disable_admission_control) { again, it seems better to check to see if admission_controller() != nullptr, or to have some other check, than to share flags widely. http://gerrit.cloudera.org:8080/#/c/6344/5/be/src/util/webserver.cc File be/src/util/webserver.cc: PS5, Line 192: Worker nit: dunno how much we want to bikeshed this, but I prefer "Executor" to "Worker". But either way, when is_coordinator == true, we should say "Coordinator + Worker", not just coordinator. PS5, Line 192: FLAGS_is_coordinator it would be neater to do something like: ExecEnv::GetInstance()->impala_server()->is_coordinator() ... if ExecEnv->impala_server() is ready at this point. http://gerrit.cloudera.org:8080/#/c/6344/5/www/root.tmpl File www/root.tmpl: Line 21: <h2>Impala Server Mode</h2> This template gets used for catalog and statestored as well. You need to check if impala_server_mode is set. I would also have something more concise, like: <h2>Impala Server Mode: {{impala_server_mode}}</h2> -- To view, visit http://gerrit.cloudera.org:8080/6344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c74abdbcd60ac050efa323616bd41182ceff3 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
