Dan Hecht has posted comments on this change. Change subject: IMPALA-4758: (2/2) Impala-side changes to build with latest gutil ......................................................................
Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5688/9/be/src/util/time.h File be/src/util/time.h: Line 36: return ts.tv_sec * NANOS_PER_SEC + ts.tv_nsec; are you sure impala doesn't have a commit that introduced GetMonoTimeNanos() that we should just cherry-pick? It might have been done that way to get it working on macos. If we don't, this is fine (though I don't see why kudu would have deleted that code). http://gerrit.cloudera.org:8080/#/c/5688/9/cmake_modules/kudu_cmake_fns.txt File cmake_modules/kudu_cmake_fns.txt: Line 64: endif() what do these two changes do and why are they needed now? -- To view, visit http://gerrit.cloudera.org:8080/5688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ac21d7d6401f21fcdfdd1132b8f322bfba4bb80 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
