Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: Remove undefined behavior: left shift of negative values ......................................................................
IMPALA-5031: Remove undefined behavior: left shift of negative values Left shift of negative values is undefined According to C++14 section 5.8 [expr.shift], paragraph 2. Change-Id: I9d965c3950a878c0a41b374d51bbe2e5705b3360 Reviewed-on: http://gerrit.cloudera.org:8080/6491 Reviewed-by: Dan Hecht <[email protected]> Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exec/read-write-util.cc M be/src/exec/zigzag-test.cc M be/src/exprs/bit-byte-functions-ir.cc 3 files changed, 6 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved Dan Hecht: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/6491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d965c3950a878c0a41b374d51bbe2e5705b3360 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
