Michael Ho has posted comments on this change. Change subject: IMPALA-5128: BE Test Infrastructure ......................................................................
Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/6477/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 2093: if (FLAGS_run_exhaustive) nit: missing { } http://gerrit.cloudera.org:8080/#/c/6477/2/be/src/testutil/gtest-util.h File be/src/testutil/gtest-util.h: PS2, Line 25: DECLARE_bool(run_exhaustive); This can use a one line comment. http://gerrit.cloudera.org:8080/#/c/6477/2/bin/run-backend-tests.sh File bin/run-backend-tests.sh: Line 30: # parse command line options Not your change but it helps to add a comment that -E and -R are ctest options to exclude and include tests matching the given regular expression -- To view, visit http://gerrit.cloudera.org:8080/6477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71fe6de39dff21b21d322daf0232b0578bdff297 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
