Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build ......................................................................
Patch Set 5: (1 comment) Some of the same questions/comments apply from the util/ review http://gerrit.cloudera.org:8080/#/c/5717/5/be/src/kudu/security/token_verifier.cc File be/src/kudu/security/token_verifier.cc: Line 160: DCHECK(false); seems reasonable to add this upstream -- To view, visit http://gerrit.cloudera.org:8080/5717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f327810066bee7f3ac107b0295480fb9ed45e14 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
