Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4883: Union Codegen ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6459/4/be/src/exec/union-node-ir.cc File be/src/exec/union-node-ir.cc: Line 28: while (!dst_batch->AtCapacity() && child_row_idx_ < child_batch_->num_rows()) { > The remaining optimisation is to pull all references to member variables ou Done. I think I took everything out. Let me know if you see any other ways to further improve performance. Line 34: if (ReachedLimit()) break; > We can avoid checking limits for each row if we check it at the end and tru Good idea, done. (We already do a similar thing in the passthrough case) -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
