Greg Rahn has posted comments on this change. Change subject: IMPALA-3381: Support AM/PM marker in date and time format strings ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6523/1/be/src/runtime/timestamp-parse-util.cc File be/src/runtime/timestamp-parse-util.cc: Line 173: case 'a': tok_type = AM_PM_MARKER; dt_ctx->has_am_pm_marker = true; break; > I decided to use "a" for the AM/PM marker because this is what Hive does. The mask can not hard-code any value -- it is how to interpret the date/time string. If the input string contains no AM/PM string then the mask should not attempt to add it and it needs to be read as 24h time. For example if the value is '2000-01-01 05:00' one should not be able to use a mask to make this be interpreted as '2000-01-01 05:00 PM'. -- To view, visit http://gerrit.cloudera.org:8080/6523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99794a3e152f1712c6c469bb266d23a81d19ca34 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
