John Russell has posted comments on this change. Change subject: IMPALA-4643: [DOCS] Change URLs / set up keydefs for JIRA reports ......................................................................
Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/6515/1/docs/topics/impala_fixed_issues.xml File docs/topics/impala_fixed_issues.xml: PS1, Line 59: ="jira_list_280"/>. > This works, but why not make it jira_list_280? Done PS1, Line 573: <xref href="impala_fixed_issues.xml#fixed_issues_232"/> > This didn't work for me. It seems as if there is no fixed_issues_232 anchor Done PS1, Line 573: fixed_issues_232 > I looked in "impala_fixed_issues.xml" and there IS a concept id "fixed_issu I believe this is a bug in the HTML transform. Why don't we classify that as out-of-scope for this particular gerrit. PS1, Line 2461: <xref keyref="jira_list_212"/ > This points to empty search results. As I said in the commit message, there are some releases where maybe nobody did the appropriate JIRA hookup for upstream issues. I'm reproducing the experience readers had in the Cloudera Impala docs, good or bad, just without any Cloudera-specific references. PS1, Line 2688: <xref keyref="jira_list_205"/> > This points to empty search results: As stated above, I'm proposing that that's out of scope for this gerrit. PS1, Line 2706: <xref keyref="jira_list_204"/> > This points to empty search results: As stated above, I'm proposing that that's out of scope for this gerrit. PS1, Line 2770: <xref keyref="jira_list_203"/ > This points to empty search results: As stated above, I'm proposing that that's out of scope for this gerrit. PS1, Line 2820: <xref keyref="jira_list_202"/> > This points to empty search results: As stated above, I'm proposing that that's out of scope for this gerrit. http://gerrit.cloudera.org:8080/#/c/6515/1/docs/topics/impala_known_issues.xml File docs/topics/impala_known_issues.xml: PS1, Line 96: he JIRA report of blocker/critical issues: > Doesn't work. Gerrit did truncate it when I copied the URL. This is invisible comment, part of a comment only. Why don't I just remove this link from the comment. -- To view, visit http://gerrit.cloudera.org:8080/6515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I007e634f9da57289674683dd5bf64e3e3ca8f525 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Laurel Hale <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
