Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5154: Handle 'unpartitioned' Kudu tables
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6560/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

Line 483:        it can be created directly in Kudu and then loaded as an 
external table.
> if this is harmless/useful functionality, should impala also support it?
I had talked to DanB about it previously, and he said they want people to move 
away from creating tables like this but that they didn't want to break 
backwards compatibility in the client.


Line 500:         cursor.execute("SELECT COUNT(*) FROM %s" % name)
> Just curious: Can we insert into the table? Is this table expected to suppo
It should behave normally after it's created, we don't know anything about the 
partitioning. I'll modify this test to insert as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/6560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40926bf6ea46cfca518bba6d4ca13fb5b0de358d
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: Yes

Reply via email to