Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5182: Explicitly close connection to impalad on error from shell ......................................................................
Patch Set 1: (1 comment) > (1 comment) > > Were you able to repro the issue? Do you think it's easy/feasible > to add a test? Yes, I was able to repro it, but only on clusters with LDAP enabled. I found this issue by looking at the thread stacks during the hang. The repro steps are: - Connect with "impala-shell -l -u <user> --ssl" - Give an incorrect LDAP password - Open another terminal and try to open impala-shell, and it hangs (until you kill the impala-shell on the first terminal) When you give an incorrect LDAP password, you get the following error in the shell: "Error connecting: TTransportException, TSocket read 0 bytes" However, when you try repro-ing with only SSL (and no LDAP), i.e. use a wrong CA cert from the impala-shell, we get the following error: "Error connecting: TTransportException, Could not connect to localhost:21000" and the above hang is not reproducible. In the LDAP case, it connects to the impalad using SSL and then requests for the LDAP password. In the only SSL case, it's not even able to connect to the impalad and therefore the hang doesn't happen. So since we unfortunately don't have LDAP for our unit testing, we can't include a test for this. http://gerrit.cloudera.org:8080/#/c/6587/1/shell/impala_shell.py File shell/impala_shell.py: Line 708: # Secure connections may still be open. So we explicitly close it. > connection (singular) Done -- To view, visit http://gerrit.cloudera.org:8080/6587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I814df93bbcd457ad3f96b4c1ef5d8b0ddd6d141f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
