Michael Brown has posted comments on this change. Change subject: IMPALA-3794: Workaround for Breakpad ID conflicts ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6588/2/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS2, Line 156: self.assert_num_logfile_entries(1) : # IMPALA-3794 / Breakpad-681: Weak minidump ID generation can lead to name conflicts, : # so that one process overwrites the minidump of others. See IMPALA-3794 for more : # information. : # TODO: Change this here and elsewhere in this file to expect 'cluster_size' minidumps : # once Breakpad-681 has been fixed. : assert self.count_minidumps('impalad') >= 1 : assert self.count_minidumps('statestored') == 1 : assert self.count_minidumps('catalogd') == 1 Any interest in making this a private method that is called L183, L201, etc.? You reduce maintenance, and now your L157-161 note applies in the one place it matters. -- To view, visit http://gerrit.cloudera.org:8080/6588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ae589f6eb5cbbfb860943214edc0e6415eeb862 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
