Michael Brown has posted comments on this change. Change subject: IMPALA-3794: Workaround for Breakpad ID conflicts ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/6588/4/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS4, Line 83: self.start_cluster_with_args(minidump_path=self.tmp_dir, : max_minidumps=self.MAX_MINIDUMPS) Sorry, but this isn't correct for PEP-008. It was fine how it was, or you have to start the first param on the second line as well, like: self.start_cluster_with_args( minidump_path=self.tmp_dir, max_minidumps=self.MAX_MINIDUMPS) PS4, Line 99: # time.sleep(1) ?? -- To view, visit http://gerrit.cloudera.org:8080/6588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ae589f6eb5cbbfb860943214edc0e6415eeb862 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
