Attila Jeges has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer ......................................................................
Patch Set 6: (2 comments) Thanks for the review. http://gerrit.cloudera.org:8080/#/c/6107/6/be/src/exec/read-write-util.h File be/src/exec/read-write-util.h: PS6, Line 247: DCHECK(val < -112); > nit: DCHECK_LT(val, -112); Done PS6, Line 258: DCHECK(val > 127); > nit: DCHECK_GT(val, 127); Done -- To view, visit http://gerrit.cloudera.org:8080/6107 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
