Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/5589/2/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: PS2, Line 335: 1 > Done What line? I don't see it. Line 406: select instr('hello world','o',-1); > Done What line is the negative position argument and an occurence argument on? 444 and 447 are invalid input. http://gerrit.cloudera.org:8080/#/c/5589/4/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: PS4, Line 352: +------------------------------------+ not exactly: that position does not exist. PS4, Line 415: 'o', fourth -- To view, visit http://gerrit.cloudera.org:8080/5589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
