Michael Ho has posted comments on this change. Change subject: IMPALA-4883: Union Codegen ......................................................................
Patch Set 10: Code-Review+1 A quick remark is that the simplification done in this patch may regress certain queries with union node containing expressions which are expensive to materialize. Previously, we would have stopped materializing once we reached the limit but now we would proceed until we hit a row batch limit. Dan, can you please take one last pass ? -- To view, visit http://gerrit.cloudera.org:8080/6459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4107d27582ff5416172810364a6e76d3d93c439 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
