Alex Behm has posted comments on this change. Change subject: IMPALA-4731/IMPALA-397/IMPALA-4728: Materialize sort exprs ......................................................................
Patch Set 6: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/6322/6/fe/src/main/java/org/apache/impala/analysis/SortInfo.java File fe/src/main/java/org/apache/impala/analysis/SortInfo.java: Line 167: * output by the sort node. Done by materializing exprs in the order-by that need to be Suggest simplifying this part "Done by materializing ..." to: Materializes slots required by 'resultExprs' as well as non-deterministic and expensive order by exprs. That description is less procedural. Line 186: // Case 1: nit: newline before "Case 1" http://gerrit.cloudera.org:8080/#/c/6322/4/tests/query_test/test_sort.py File tests/query_test/test_sort.py: Line 158: class TestRandomSort(ImpalaTestSuite): > Because I'm not taking 'vector' as a parameter to the tests, they will only Thanks for explaining, you are right. The current solution seems best to me. -- To view, visit http://gerrit.cloudera.org:8080/6322 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefdaff8557a30ac44ea82ed428e6d1ffbca2e9e Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
