Tim Armstrong has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/5538/8/fe/src/compat-hive-1/java/org/apache/hive/service/rpc/thrift/TGetTablesReq.java File fe/src/compat-hive-1/java/org/apache/hive/service/rpc/thrift/TGetTablesReq.java: Line 1: package org.apache.hive.service.rpc.thrift; > Apache license in the newly added classes? Done http://gerrit.cloudera.org:8080/#/c/5538/8/fe/src/compat-hive-1/java/org/apache/impala/compat/MetaStoreShim.java File fe/src/compat-hive-1/java/org/apache/impala/compat/MetaStoreShim.java: Line 16: // under the License. > nit: \n after license. Done -- To view, visit http://gerrit.cloudera.org:8080/5538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc265281c04fe3136bc3c920dbac966742ce09a Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
