Alex Behm has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6610/1/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 344: // The vectors get copied because we intend to sort them and it is better to keep this How about solving this in the FE? We already have a function TupleDescriptor.getSlotsOrderedByOffset() and you can use that in DescriptorTable.toThrift() in L187. -- To view, visit http://gerrit.cloudera.org:8080/6610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426ad244678dbfe517262dfb7bbf4adc0247a35e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
